Create a WildcardMatcher.NONE when creating a WildcardMatcher with an empty string#69
Open
Create a WildcardMatcher.NONE when creating a WildcardMatcher with an empty string#69
Conversation
… empty string Signed-off-by: Craig Perkins <cwperx@amazon.com>
kkhatua
reviewed
Oct 9, 2025
|
|
||
| public static WildcardMatcher from(String pattern) { | ||
| if (pattern == null) { | ||
| if (pattern == null || pattern.isBlank()) { |
There was a problem hiding this comment.
Should you perform a trim() on the pattern as well ?
Owner
Author
There was a problem hiding this comment.
trim() isn't necessary since isBlank() will return true if the string is only whitespace: https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/String.html#isBlank()
Signed-off-by: Craig Perkins <cwperx@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behavior of WildcardMatcher slightly to create a WildcardMatcher.NONE if a caller tries to create a WildcardMatcher from an empty string.
Bug fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.